[Mlir-commits] [mlir] [MLIR] RemoveDeadValues: Allowing IRs with global constants to get dead values removed (PR #116519)

M. Zeeshan Siddiqui llvmlistbot at llvm.org
Fri Nov 22 08:20:13 PST 2024


codemzs wrote:

> It's not clear why this check is in-place (unfortunately the comment documents the "what" and not the "why"...).
> 
> In any case we could tighten this back with motivating examples, if they show up, and I suspect the checks could be more targeted: for example instead of disabling the pass entirely, we could disable it on a per-function basis.

@joker-eph I was curious if there is anything else needed for this change to be committed? 

https://github.com/llvm/llvm-project/pull/116519


More information about the Mlir-commits mailing list