[Mlir-commits] [mlir] [MLIR] RemoveDeadValues: Allowing IRs with global constants to get dead values removed (PR #116519)

[Mehdi Amini]

https://github.com/joker-eph approved this pull request.

It's not clear why this check is in-place (unfortunately the comment documents the "what" and not the "why"...).

In any case we could tighten this back with motivating examples, if they show up, and I suspect the checks could be more targeted: for example instead of disabling the pass entirely, we could disable it on a per-function basis.

https://github.com/llvm/llvm-project/pull/116519