[Mlir-commits] [mlir] [mlir][Vector] Add support for 0-d shapes in extract-shape_cast folder (PR #116650)

[Andrzej Warzyński]

banach-space wrote:

> That's a pretty large design change, no?

>From my perspective, having reviewed and refactored a fair amount of Vector patterns, I don’t think it represents a major design shift. That said, I could be overlooking something important, and this is precisely why I believe an RFC would be valuable - it would help clarify any potential concerns or implications we might not have considered.

> Just warning that I think such an RFC will be a quite difficult discussion and might not be profitable.

In my view, the existing handling of 0-D vectors introduces a fair amount of confusion and misunderstanding. An RFC would create an opportunity to bring these issues to light, better define our needs as a community, and address any misalignments. Even if we ultimately decide to keep 0-D vectors, we could use the discussion to clarify ambiguities (of which there are many!) and improve consistency. Surely, that would benefit the community and strengthen the foundation we’re building on.

https://github.com/llvm/llvm-project/pull/116650