[Mlir-commits] [mlir] [mlir][Vector] Add support for 0-d shapes in extract-shape_cast folder (PR #116650)

[Stella Laurenzo]

stellaraccident wrote:

> Thanks!
> 
> Just for viz., I was planning to send an RFC (EOW or ENW) to remove support for 0-D vectors from the vector type. The number of bugs we are dealing with and special-casing we are introducing to support 0-D vectors is not worth the value they bring (which it's still unclear to me). So, if you have any specific concerns about that idea, it would be great to know sooner than later (Discord?) :)

That's a pretty large design change, no? Not that such things can't be justified, but remember: the vector dialect does not "own" the built-in vector type (and many would argue, is not even the primary user of the type). I think it is fine to propose something new, but at what point does this become "vector dialect2 -- now with its own type and specific opinions on dimensionality"?

Just warning that I think such an RFC will be a quite difficult discussion and might not be profitable.

https://github.com/llvm/llvm-project/pull/116650