[Mlir-commits] [mlir] [mlir][Tensor] Retain discardable attrs in pack(cast) folder (PR #115772)

[Mehdi Amini]

joker-eph wrote:

Note that the project stance on discardable attributes was debated quite a few times, some of the pointer:

- https://discourse.llvm.org/t/mlir-ensuring-namedattributes-propagate-through-pass-pipeline/63421/2
- https://discourse.llvm.org/t/rfc-implicit-propagation-of-dialect-attributes-best-effort/2657/16
- And we had an ODM on the topic: https://discourse.llvm.org/t/odm-tomorrow-2-4-discuss-the-role-of-dialect-attributes-merging-and-propagation/2725
- See also Chris' message here which still seems pretty relevant: https://discourse.llvm.org/t/on-querying-an-operations-intrinsic-core-vs-external-user-defined-attributes/4498/2

They were not initially called like this by the way, it's after one of these discussions that we felt the need to be explicit about the intent and picked the term "discardable": https://reviews.llvm.org/D96093



https://github.com/llvm/llvm-project/pull/115772