[Mlir-commits] [mlir] [mlir][Tensor] Retain discardable attrs in pack(cast) folder (PR #115772)

[Mehdi Amini]

joker-eph wrote:

> This is literally the use case here. In my book, the real issue here is that this transformation could have been done in-place, in which case there would not be an issue.

I don't believe so: a correct and sound transformation in-place would also explicitly drop these attributes.

> We dont need to dictate how the whole world builds compilers. 

Indeed: you do whatever you want downstream, but we have a consistent project upstream where we need to adhere to some principled and consistent designs.


https://github.com/llvm/llvm-project/pull/115772