[Mlir-commits] [mlir] [mlir][llvm] Add support for memset.inline (PR #115711)

Tobias Gysi llvmlistbot at llvm.org
Mon Nov 11 08:21:04 PST 2024


================
@@ -931,38 +939,52 @@ static bool areAllIndicesI32(const DestructurableMemorySlot &slot) {
 }
 
 //===----------------------------------------------------------------------===//
-// Interfaces for memset
+// Interfaces for memset && memset.inline
 //===----------------------------------------------------------------------===//
 
-bool LLVM::MemsetOp::loadsFrom(const MemorySlot &slot) { return false; }
+template <class MemsetLike>
+static bool memsetCanRewire(MemsetLike op, const DestructurableMemorySlot &slot,
----------------
gysit wrote:

Normally a function name should start with a verb. I would thus move the memset further back in the name similar to what we did above. E.g.:

canRewireMemsetIntr
getStoredValueOfMemsetIntr
etc.

https://github.com/llvm/llvm-project/pull/115711


More information about the Mlir-commits mailing list