[Mlir-commits] [mlir] [mlir][llvm] Add support for memset.inline (PR #115711)

[Tobias Gysi]

https://github.com/gysit commented:

Thanks for adding the intrinsic!

The code already looks good modulo some style / nit comments. Additionally it makes sense to add some more tests.

An import test for the new intrinsic definitely makes sense. I could be added here:
https://github.com/llvm/llvm-project/blob/3fcb9684cf6ba4ff9009ebabd9ff966eeb8b15f7/mlir/test/Target/LLVMIR/Import/intrinsic.ll#L505

Additionally, it could make sense to test that mem2reg and sroa work properly using your interface implementations. I added the relevant test files below. Since the logic is not duplicated it maybe sufficient to duplicate some test that covers the specialized code (possibly it is even sufficient to use the new intrinsic in some test cases). 
https://github.com/llvm/llvm-project/blob/4981f8cb72ea7d04da601c868763b38bdc11e74e/mlir/test/Dialect/LLVMIR/mem2reg-intrinsics.mlir
https://github.com/llvm/llvm-project/blob/4981f8cb72ea7d04da601c868763b38bdc11e74e/mlir/test/Dialect/LLVMIR/sroa-intrinsics.mlir


https://github.com/llvm/llvm-project/pull/115711