[Mlir-commits] [flang] [llvm] [mlir] [Flang]Fix for changed code at the end of AllocaIP. (PR #92430)
Tom Eccles
llvmlistbot at llvm.org
Wed May 29 10:43:28 PDT 2024
https://github.com/tblah commented:
Thanks for the changes.
@Meinersbur thank you for your comments. I agree that it would be better for all allocas to come first in the entry block and not to be inserted after conditionals. But I think this is out of scope of this PR, which is trying to fix an assertion failure while building a real application.
Would it be acceptable for you if we addressed the alloca placement in a later patch?
https://github.com/llvm/llvm-project/pull/92430
More information about the Mlir-commits
mailing list