[Mlir-commits] [flang] [llvm] [mlir] [Flang]Fix for changed code at the end of AllocaIP. (PR #92430)

[Tom Eccles]

================
@@ -1217,7 +1221,10 @@ convertOmpParallel(omp::ParallelOp opInst, llvm::IRBuilderBase &builder,
       assert(phis.size() == 1 &&
              "expected one value to be yielded from the "
              "reduction neutral element declaration region");
-
+      if (initBlock)
----------------
tblah wrote:

Why not use a separate init block for the by-val case as well? I know we currently happen to only have simple allocas in the init region of by val reductions. But this isn't what the by-ref attribute (or not) is guaranteeing. 

https://github.com/llvm/llvm-project/pull/92430