[Mlir-commits] [mlir] [mlir][test] Rename SVE + SME integration tests (nfc) (PR #93521)

Cullen Rhodes llvmlistbot at llvm.org
Wed May 29 01:09:14 PDT 2024


c-rhodes wrote:

> Thanks for taking a look!
> 
> Consistency is important, I agree. Re tests in "mlir/test/Integration/Dialect/Vector/CPU/", I suggest renaming those tests as well.

👍

~40% of the integration tests (118/303) have the prefix, not sure how far you want to take it.

> 
> IMHO, adding "test-" to filenames inside a **test** directory is noise that can be avoided. The information that these files are **test** files is already encoded in the directory name - no need to repeat that in the filename.

I agree.

https://github.com/llvm/llvm-project/pull/93521


More information about the Mlir-commits mailing list