[Mlir-commits] [mlir] [mlir][test] Rename SVE + SME integration tests (nfc) (PR #93521)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue May 28 12:53:07 PDT 2024


banach-space wrote:

Thanks for taking a look! 

Consistency is important, I agree. Re  tests in "mlir/test/Integration/Dialect/Vector/CPU/", I suggest renaming those tests as well. 

IMHO, adding "test-" to filenames inside a **test** directory is noise that can be avoided. The information that these files are **test** files is already encoded in the directory name - no need to repeat that in the filename.

https://github.com/llvm/llvm-project/pull/93521


More information about the Mlir-commits mailing list