[Mlir-commits] [mlir] [mlir][affine][Analysis] Add conservative bounds for semi-affine mods (PR #93576)

Kunwar Grover llvmlistbot at llvm.org
Wed May 29 00:31:35 PDT 2024


================
@@ -413,7 +413,8 @@ class SimpleAffineExprFlattener
   /// lhs of the mod, floordiv, ceildiv or mul expression and with respect to a
   /// symbolic rhs expression. `localExpr` is the simplified tree expression
   /// (AffineExpr) corresponding to the quantifier.
-  virtual void addLocalIdSemiAffine(AffineExpr localExpr);
+  virtual void addLocalIdSemiAffine(AffineExpr localExpr, ArrayRef<int64_t> lhs,
----------------
Groverkss wrote:

nit: I would prefer if these two APIs looked more consistent.  Could you give the members the same names and same orders? Also, please update docs for addLocalIdSemiAffine.

https://github.com/llvm/llvm-project/pull/93576


More information about the Mlir-commits mailing list