[Mlir-commits] [mlir] [mlir][affine][Analysis] Add conservative bounds for semi-affine mods (PR #93576)

[Kunwar Grover]

https://github.com/Groverkss requested changes to this pull request.

Thanks for the patch. The approach for approximating is good, I'm mostly concerned about layering.

I have a few concerns about the implementation adding these overapproximation very deep into Presburger/Affine APIs. I would expect this patch to not touch them at all. This is how I think this should look like:

- Add a new method to FlatLinearValueConstraints allowing adding bounds on semi-affine expressions with a defined way of approximating.
- This method would need a new flattened. IIUC, the AffineExprFlattener is designed to be derived. I would create a SemiAffineExprFlattener which adds these approximations and flattens them and use that in this method.

https://github.com/llvm/llvm-project/pull/93576