[Mlir-commits] [mlir] [MLIR][Tensor] Canonicalize fully covering slice insertions into tensors with unit prefixes (PR #92912)

[Mehdi Amini]

joker-eph wrote:

> This is exactly my point. There is no argument to pick one over the other. So what's stopping me from writing the reverse and add that to a canonicalization?

At the moment nothing, with this patch it would be the fact that infinite loop are explicitly prohibited in our doc :)
We should be able to decide one way or another is my point, not punting.


> These kind of statements are unhelpful and do not lead to an outcome.

I mean your whole approach isn't constructive here: I'm urging you to either come back to build some basic principles upon which we can make progress, or abstain of blocking canonicalization without being able to provide stronger reasoning.

> The above discussion is not helping the author land his change. I would suggest just adding a new populate*Patterns and adding this pattern there.

I see this as avoidance in face of unjustified obstruction of being able to make progress on canonicalization: so I strongly object.


https://github.com/llvm/llvm-project/pull/92912