[Mlir-commits] [mlir] Support polynomial attributes with floating point coefficients (PR #91137)

[Mehdi Amini]

================
@@ -9,87 +9,63 @@
 #include "mlir/Dialect/Polynomial/IR/Polynomial.h"
 
 #include "mlir/Support/LogicalResult.h"
-#include "llvm/ADT/APInt.h"
-#include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/SmallVector.h"
-#include "llvm/ADT/Twine.h"
-#include "llvm/Support/raw_ostream.h"
 
 namespace mlir {
 namespace polynomial {
 
-FailureOr<Polynomial> Polynomial::fromMonomials(ArrayRef<Monomial> monomials) {
+template <typename T>
+MonomialBase<T>::~MonomialBase() {}
----------------
joker-eph wrote:

The header has it as `virtual ~MonomialBase() = 0;` ; what is this definition for then?

https://github.com/llvm/llvm-project/pull/91137