[Mlir-commits] [mlir] Support polynomial attributes with floating point coefficients (PR #91137)

Jeremy Kun llvmlistbot at llvm.org
Mon May 13 10:23:30 PDT 2024


j2kun wrote:

I think this might be a C++ thing I don't understand.

Error is

```
ld.lld: error: undefined symbol: mlir::polynomial::MonomialBase<llvm::APInt>::~MonomialBase()
>>> referenced by PolynomialDialect.cpp
>>>               PolynomialDialect.cpp.o:(mlir::polynomial::IntMonomial::~IntMonomial()) in archive lib/libMLIRPolynomialDialect.a
```

I have `~IntMonomial() = default;` which then references the base class destructor, and in `Polynomial.cpp` I have

```cpp
template <typename T>
MonomialBase<T>::~MonomialBase() {}
```

This PR also didn't change the CMakeLists.txt at all...

https://github.com/llvm/llvm-project/pull/91137


More information about the Mlir-commits mailing list