[Mlir-commits] [mlir] [MLIR][LLVM] Add `llvm.experimental.constrained.fptrunc` operation (PR #86260)

Tobias Gysi llvmlistbot at llvm.org
Fri Mar 22 05:41:47 PDT 2024


================
@@ -290,6 +290,73 @@ def GetResultPtrElementType : OpInterface<"GetResultPtrElementType"> {
   ];
 }
 
+def ExceptionBehaviorOpInterface : OpInterface<"ExceptionBehaviorOpInterface"> {
----------------
gysit wrote:

In the newer interfaces we used slightly different naming of the interface functions to avoid the naming collision with the getter generated on the operation. See for example AccessGroupOpInterface.

Do you think that would make sense here as well, e.g.:
```
getExceptionBehaviorOrNull
setExceptionBehavior
```
That way there is probably no need to return the name of the attribute. Instead the setExceptionBehavior function can be called during import.

The same could also apply to the RoundingModeOpInterface.

https://github.com/llvm/llvm-project/pull/86260


More information about the Mlir-commits mailing list