[Mlir-commits] [mlir] [mlir] Remove unused and untested `shouldSplitInputFile`. (PR #85622)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Mar 18 02:55:37 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-core

Author: Ingo Müller (ingomueller-net)

<details>
<summary>Changes</summary>

This was changed by #<!-- -->84765 but turned out to be buggy. Since it isn't used and isn't tested, it is probably best to remove it.

---
Full diff: https://github.com/llvm/llvm-project/pull/85622.diff


1 Files Affected:

- (modified) mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h (-1) 


``````````diff
diff --git a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
index 8adc80908de116..4f7f83cdb47376 100644
--- a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
+++ b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
@@ -144,7 +144,6 @@ class MlirOptMainConfig {
     splitInputFileFlag = std::move(splitMarker);
     return *this;
   }
-  bool shouldSplitInputFile() const { return splitInputFileFlag.empty(); }
   StringRef inputSplitMarker() const { return splitInputFileFlag; }
 
   /// Set whether to merge the output chunks into one file using the given

``````````

</details>


https://github.com/llvm/llvm-project/pull/85622


More information about the Mlir-commits mailing list