[Mlir-commits] [mlir] [mlir] Remove unused and untested `shouldSplitInputFile`. (PR #85622)

Ingo Müller llvmlistbot at llvm.org
Mon Mar 18 02:55:07 PDT 2024


https://github.com/ingomueller-net created https://github.com/llvm/llvm-project/pull/85622

This was changed by #84765 but turned out to be buggy. Since it isn't used and isn't tested, it is probably best to remove it.

>From bcfe465bb6d55f2bece38f9f7ed594490d1e2ea4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ingo=20M=C3=BCller?= <ingomueller at google.com>
Date: Mon, 18 Mar 2024 09:53:49 +0000
Subject: [PATCH] [mlir] Remove unused and untested `shouldSplitInputFile`.

This was changed by #84765 but turned out to be buggy. Since it isn't
used and isn't tested, it is probably best to remove it.
---
 mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
index 8adc80908de116..4f7f83cdb47376 100644
--- a/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
+++ b/mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h
@@ -144,7 +144,6 @@ class MlirOptMainConfig {
     splitInputFileFlag = std::move(splitMarker);
     return *this;
   }
-  bool shouldSplitInputFile() const { return splitInputFileFlag.empty(); }
   StringRef inputSplitMarker() const { return splitInputFileFlag; }
 
   /// Set whether to merge the output chunks into one file using the given



More information about the Mlir-commits mailing list