[Mlir-commits] [flang] [mlir] [MLIR][OpenMP] NFC: Uniformize OpenMP ops names (PR #85393)

[Krzysztof Parzyszek]

kparzysz wrote:

> * `omp.critical.declare` -> `omp.critical_declare` / `omp.declare.critical` / keep it unchanged?
> * `omp.reduction.declare` -> `omp.reduction_declare` / `omp.declare.reduction` / keep it unchanged?

The first one doesn't exist in the spec, the second one is "declare reduction", so for consistency we should use the names with "declare_xyz".

> * `omp.atomic.read` -> `omp.atomic_read`
> * `omp.atomic.write` -> `omp.atomic_write`
> * `omp.atomic.update` -> `omp.atomic_update`
> * `omp.atomic.capture` -> `omp.atomic_capture`

The "read", "write", etc. are clauses, so "atomic read" is not a name.  I suggest keeping the . as a separator here.

https://github.com/llvm/llvm-project/pull/85393