[Mlir-commits] [flang] [mlir] [MLIR][OpenMP] NFC: Uniformize OpenMP ops names (PR #85393)

[Sergio Afonso]

skatrak wrote:

Thank you Krzysztof for sharing your thoughts. I don't personally have an issue either way with regards to using dots or underscores for separating words in MLIR ops. The issue at the moment is that we use both, so it'd be nice to make it uniform. If we prefer underscores, then rather than changing the operation names that I initially proposed, in my opinion we should change these instead:
- `omp.critical.declare` -> `omp.critical_declare` / `omp.declare.critical` / keep it unchanged?
- `omp.reduction.declare` -> `omp.reduction_declare` / `omp.declare.reduction` / keep it unchanged?
- `omp.atomic.read` -> `omp.atomic_read`
- `omp.atomic.write` -> `omp.atomic_write`
- `omp.atomic.update` -> `omp.atomic_update`
- `omp.atomic.capture` -> `omp.atomic_capture`

https://github.com/llvm/llvm-project/pull/85393