[Mlir-commits] [mlir] Get rid of noisy debug log in verifyOpAndAdjustFlags. (PR #84677)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Justin Lebar (jlebar)

<details>
<summary>Changes</summary>

This debug log adds noise to a large fraction of *other* debug logs when you
run with -debug, because it prints "Verifying operation: blah blah\n" whenever
those other debug logs dump an op.

You can use -debug-only to get around this, but sometimes -debug really is
what's called for!


---
Full diff: https://github.com/llvm/llvm-project/pull/84677.diff


1 Files Affected:

- (modified) mlir/lib/IR/AsmPrinter.cpp (-3) 


``````````diff
diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 8d75349f8eed45..456cf6a2c27783 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -1895,9 +1895,6 @@ static OpPrintingFlags verifyOpAndAdjustFlags(Operation *op,
       printerFlags.shouldAssumeVerified())
     return printerFlags;
 
-  LLVM_DEBUG(llvm::dbgs() << DEBUG_TYPE << ": Verifying operation: "
-                          << op->getName() << "\n");
-
   // Ignore errors emitted by the verifier. We check the thread id to avoid
   // consuming other threads' errors.
   auto parentThreadId = llvm::get_threadid();

``````````

</details>


https://github.com/llvm/llvm-project/pull/84677