[Mlir-commits] [mlir] Get rid of noisy debug log in verifyOpAndAdjustFlags. (PR #84677)

[Justin Lebar]

https://github.com/jlebar created https://github.com/llvm/llvm-project/pull/84677

This debug log adds noise to a large fraction of *other* debug logs when you
run with -debug, because it prints "Verifying operation: blah blah\n" whenever
those other debug logs dump an op.

You can use -debug-only to get around this, but sometimes -debug really is
what's called for!


>From 748558719a3c96694c9a116c005c640d7836ec66 Mon Sep 17 00:00:00 2001
From: Justin Lebar <justin.lebar at gmail.com>
Date: Sun, 10 Mar 2024 07:00:18 -0700
Subject: [PATCH] Get rid of noisy debug log in verifyOpAndAdjustFlags.

This debug log adds noise to a large fraction of *other* debug logs when you
run with -debug, because it prints "Verifying operation: blah blah\n" whenever
those other debug logs dump an op.

You can use -debug-only to get around this, but sometimes -debug really is
what's called for!
---
 mlir/lib/IR/AsmPrinter.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mlir/lib/IR/AsmPrinter.cpp b/mlir/lib/IR/AsmPrinter.cpp
index 8d75349f8eed45..456cf6a2c27783 100644
--- a/mlir/lib/IR/AsmPrinter.cpp
+++ b/mlir/lib/IR/AsmPrinter.cpp
@@ -1895,9 +1895,6 @@ static OpPrintingFlags verifyOpAndAdjustFlags(Operation *op,
       printerFlags.shouldAssumeVerified())
     return printerFlags;
 
-  LLVM_DEBUG(llvm::dbgs() << DEBUG_TYPE << ": Verifying operation: "
-                          << op->getName() << "\n");
-
   // Ignore errors emitted by the verifier. We check the thread id to avoid
   // consuming other threads' errors.
   auto parentThreadId = llvm::get_threadid();