[Mlir-commits] [mlir] mlir/Presburger: strip dependency on MLIRSupport (PR #96517)
Mehdi Amini
llvmlistbot at llvm.org
Sun Jun 30 14:04:45 PDT 2024
joker-eph wrote:
> some functions don't say anything about the return but the type of LogicalResult previously made it clear that the return denotes success/failure, which now becomes unclear. Please add a line to the header doc in such cases mentioning that the function returns true if successful.
Better: can we please keep LogicalResult!! (move the header to LLVMSupport instead)
https://github.com/llvm/llvm-project/pull/96517
More information about the Mlir-commits
mailing list