[Mlir-commits] [mlir] mlir/Presburger: strip dependency on MLIRSupport (PR #96517)

[Arjun P]

https://github.com/Superty commented:

Thanks for your patch. Please fix these two issues:
1. many comments refer to `returns failure if...` or `returns success if...`. Please fix to say `returns true/false`.
2. some functions don't say anything about the return but the type of LogicalResult previously made it clear that the return denotes success/failure, which now becomes unclear. Please add a line to the header doc in such cases mentioning that the function returns true if successful. 



https://github.com/llvm/llvm-project/pull/96517