[Mlir-commits] [mlir] [mlir][vector] Always print the in_bounds attribute (PR #96031)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri Jun 28 05:56:39 PDT 2024


banach-space wrote:

> 1) fix no-attribute == in-bounds assumption (this would let you test what you want without making the default printing explicit) 

As per Ben's comment, I was wrong and this doesn't require fixing. I'm still unable to test what I want, but I can work around it.

> 2) make the attribute mandatory, with default value set to false

Note, this will require updating _a lot_ of tests. I've prepared a draft PR in which I refactored just one of the affected tests (to illustrate): 
* https://github.com/llvm/llvm-project/pull/97049/

There's 159 test files that use Vector xfer Ops, so I'll need to update a fair bit. This is also likely to have quite an impact on downstream. CC @hanhanW 

https://github.com/llvm/llvm-project/pull/96031


More information about the Mlir-commits mailing list