[Mlir-commits] [mlir] [mlir][vector] Always print the in_bounds attribute (PR #96031)

Andrzej Warzyński llvmlistbot at llvm.org
Thu Jun 27 01:47:33 PDT 2024


banach-space wrote:

> > > right now the default is "no attribute", which is treated as "in bounds"
> 
> > Really? Wow, that's really wrong! We can't assume that accesses are in-bounds by default. That would lead to correctness issues... Do you have a pointer to code where this assumption is made?
> 
> This is not the case, as shown in the snippet linked in [#96031 (comment)](https://github.com/llvm/llvm-project/pull/96031#issuecomment-2183985697), no in-bounds attributes is interpreted as the dim being out-of-bounds.

Ben is right and I was wrong - thanks for pointing it out and apologies for the confusion! (I was looking at something that made me believe that what I said was correct, but after double-checking I see that i was mistaken) 🙏🏻 

https://github.com/llvm/llvm-project/pull/96031


More information about the Mlir-commits mailing list