[Mlir-commits] [mlir] [MLIR][Python] fix mlir python cmake script (PR #95939)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jun 18 08:04:50 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Bimo (xurui1995)

<details>
<summary>Changes</summary>

Encountered a problem when linking multiple CAPI libs.
The `COMMON_CAPI_LINK_LIBS` should be multi_value_keywords here.

---
Full diff: https://github.com/llvm/llvm-project/pull/95939.diff


1 Files Affected:

- (modified) mlir/cmake/modules/AddMLIRPython.cmake (+2-2) 


``````````diff
diff --git a/mlir/cmake/modules/AddMLIRPython.cmake b/mlir/cmake/modules/AddMLIRPython.cmake
index 012380603a4c4..f030798a94ae9 100644
--- a/mlir/cmake/modules/AddMLIRPython.cmake
+++ b/mlir/cmake/modules/AddMLIRPython.cmake
@@ -203,8 +203,8 @@ endfunction()
 function(add_mlir_python_modules name)
   cmake_parse_arguments(ARG
     ""
-    "ROOT_PREFIX;INSTALL_PREFIX;COMMON_CAPI_LINK_LIBS"
-    "DECLARED_SOURCES"
+    "ROOT_PREFIX;INSTALL_PREFIX"
+    "COMMON_CAPI_LINK_LIBS;DECLARED_SOURCES"
     ${ARGN})
   # Helper to process an individual target.
   function(_process_target modules_target sources_target)

``````````

</details>


https://github.com/llvm/llvm-project/pull/95939


More information about the Mlir-commits mailing list