[Mlir-commits] [mlir] [MLIR][Python] fix mlir python cmake script (PR #95939)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jun 18 08:04:19 PDT 2024


https://github.com/xurui1995 created https://github.com/llvm/llvm-project/pull/95939

Encountered a problem when linking multiple CAPI libs.
The `COMMON_CAPI_LINK_LIBS` should be multi_value_keywords here.

>From 0508105e4b35b996790c0c8af0dc559dd63a4a6b Mon Sep 17 00:00:00 2001
From: "Xu, Rui" <rui.xu at intel.com>
Date: Tue, 18 Jun 2024 22:57:45 +0800
Subject: [PATCH] [MLIR][Python] fix add mlir python cmake

---
 mlir/cmake/modules/AddMLIRPython.cmake | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/cmake/modules/AddMLIRPython.cmake b/mlir/cmake/modules/AddMLIRPython.cmake
index 012380603a4c4..f030798a94ae9 100644
--- a/mlir/cmake/modules/AddMLIRPython.cmake
+++ b/mlir/cmake/modules/AddMLIRPython.cmake
@@ -203,8 +203,8 @@ endfunction()
 function(add_mlir_python_modules name)
   cmake_parse_arguments(ARG
     ""
-    "ROOT_PREFIX;INSTALL_PREFIX;COMMON_CAPI_LINK_LIBS"
-    "DECLARED_SOURCES"
+    "ROOT_PREFIX;INSTALL_PREFIX"
+    "COMMON_CAPI_LINK_LIBS;DECLARED_SOURCES"
     ${ARGN})
   # Helper to process an individual target.
   function(_process_target modules_target sources_target)



More information about the Mlir-commits mailing list