[Mlir-commits] [mlir] [mlir][SCF] Deprecate `linalg::tileToForallOp` and `linalg::tileToForallOpUsingTileSizes` (PR #91878)

[llvmlistbot at llvm.org]

MaheshRavishankar wrote:

> > And the changes appear fairly mechanical and _should_ not be changing behavior, although it looks like from the above discussion there are some unexpected functionality changes
> 
> Right, this should not happen. Best thing is to split in two patches and land the refactory first, then the functionality change.

There is no functionality change. Please take a look at the lit tests. The old path is _somehow_ wrong. And it is fairly obvious that the test is also wrong. What you are essentially asking me to do is to find the bug in the old code, introduce it in the new code, and then fix it... I dont see why that is needed. I have taken special care to avoid too much change in lit test (to the extent to also make sure the order of operands to `affine.apply` etc are consistent to avoid lit test churn. But I dont see a reason to deliberately introduce a bug.


https://github.com/llvm/llvm-project/pull/91878