[Mlir-commits] [mlir] [mlir][SCF] Deprecate `linalg::tileToForallOp` and `linalg::tileToForallOpUsingTileSizes` (PR #91878)

Renato Golin llvmlistbot at llvm.org
Sat Jun 1 15:12:07 PDT 2024


rengolin wrote:

> And the changes appear fairly mechanical and _should_ not be changing behavior, although it looks like from the above discussion there are some unexpected functionality changes

Right, this should not happen. Best thing is to split in two patches and land the refactory first, then the functionality change.

> I asked about this above, and the plan was to leave clear instructions on how to move to the new SCF API. We had one remaining use in IREE that I prefetched and migrated here: [iree-org/iree at 3f51d4f#diff-2bafce15cac72329fb12f66603e07a3f7535df2e6225944be07a5729ca914eebL280-R294](https://github.com/iree-org/iree/commit/3f51d4ffd4e1a91b718817742eb9b5a7b5c29a90#diff-2bafce15cac72329fb12f66603e07a3f7535df2e6225944be07a5729ca914eebL280-R294)

Thanks! @adam-smnk we should make sure this doesn't change the semantics for us, either.

> I updated the PR description to how you can change your use case to map to using `scf::tileUsingSCF`.

Very helpful, thanks!

https://github.com/llvm/llvm-project/pull/91878


More information about the Mlir-commits mailing list