[Mlir-commits] [mlir] [MLIR][SCF] Define `-scf-rotate-while` pass (PR #99850)

[Victor Perez]

victor-eds wrote:

> Sorry I don't understand your answer, it does not seem you're addressing the question actually: why did you need to "create a pass" when there was already one that could just be updated? 

The *original* pass was a test pass under `test/lib/Dialect/SCF`. This pass was created to test the function I'm using for the implementation of the new pass. As my new pass already covers the case for `forceCreateCheck=false`, I limited the scope of this already existing *test* pass.

> Why should this pass be anywhere else than inside the Transform directory?

My new pass isn't a test pass and it's located under `Dialect/SCF/Transforms`.


https://github.com/llvm/llvm-project/pull/99850