[Mlir-commits] [mlir] [MLIR][SCF] Define `-scf-rotate-while` pass (PR #99850)

[Mehdi Amini]

joker-eph wrote:

> > From the comment thread, it's not clear why the pass is moved out of the test directory?
> 
> I decided it may be useful to create a pass to expose the pattern. Testing that pass covers `wrapWhileLoopInZeroTripCheck` with `forceCreateCheck=false`, as that's the only behavior the pass and the pattern expose. The test pass is kept, but just to check `forceCreateCheck=true`.

Sorry I don't understand your answer, it does not seem you're addressing the question actually: why did you need to "create a pass" when there was already one that could just be updated? Why should this pass be anywhere else than inside the Transform directory?

https://github.com/llvm/llvm-project/pull/99850