[Mlir-commits] [mlir] [MLIR][Linalg] Add aggregate ops decomposition pass and softmax decom… (PR #97582)

Petr Kurapov llvmlistbot at llvm.org
Sun Jul 7 03:56:02 PDT 2024


================
@@ -30,6 +30,16 @@ class IteratorTypeAttr;
 class LinalgOp;
 class GenericOp;
 
+/// Container for result values of decomposition.
+/// - `decomposedOps` contains operations created by the decomposition that are
+/// returned to the caller for further transformations.
+/// - `decomposedValues` contains the values corresponding to the result of the
+/// aggregate operation.
+struct DecompositionResult {
+  SmallVector<Operation *> decomposedOps;
----------------
kurapov-peter wrote:

I'm asking because this seems to be not a trivial change. `LinalgOp` is an incomplete type in the context and a forward declaration for `DecompositionResult` makes the struct an incomplete type for `FailureOr` template instantiation (in `AggregatedOpInterface`).

https://github.com/llvm/llvm-project/pull/97582


More information about the Mlir-commits mailing list