[Mlir-commits] [mlir] [MLIR][Linalg] Add aggregate ops decomposition pass and softmax decom… (PR #97582)

Renato Golin llvmlistbot at llvm.org
Sat Jul 6 16:28:36 PDT 2024


================
@@ -30,6 +30,16 @@ class IteratorTypeAttr;
 class LinalgOp;
 class GenericOp;
 
+/// Container for result values of decomposition.
+/// - `decomposedOps` contains operations created by the decomposition that are
+/// returned to the caller for further transformations.
+/// - `decomposedValues` contains the values corresponding to the result of the
+/// aggregate operation.
+struct DecompositionResult {
+  SmallVector<Operation *> decomposedOps;
----------------
rengolin wrote:

I think it makes sense to be a bit more restrictive to begin with, then expand as we have more use cases. The main problem is when someone else tries to use it for a wildly different case and complaints "it's not working" when in truth it was never intended to be supported.

https://github.com/llvm/llvm-project/pull/97582


More information about the Mlir-commits mailing list