[Mlir-commits] [mlir] [mlir][nvvm]Add support for grid_constant attribute on LLVM function arguments (PR #78228)

[Mehdi Amini]

================
@@ -58,6 +60,16 @@ class LLVMTranslationDialectInterface
                  LLVM::ModuleTranslation &moduleTranslation) const {
     return success();
   }
+
+  /// Hook for derived dialect interface to translate or act on a derived
+  /// dialect attribute that appears on a function parameter. This gets called
+  /// after the function operation has been translated.
+  virtual LogicalResult
+  convertParameterAttr(LLVM::LLVMFuncOp function, int argIdx,
----------------
joker-eph wrote:

How do you suggest to fix this: I see it as a bug and I am consistently using `signed int`  everywhere!
Should I sent patched updating every file for consistency or should we make sure new code use safer arithmetic patterns?

https://github.com/llvm/llvm-project/pull/78228