[Mlir-commits] [mlir] [mlir][nvvm]Add support for grid_constant attribute on LLVM function arguments (PR #78228)

[Oleksandr Alex Zinenko]

================
@@ -58,6 +60,16 @@ class LLVMTranslationDialectInterface
                  LLVM::ModuleTranslation &moduleTranslation) const {
     return success();
   }
+
+  /// Hook for derived dialect interface to translate or act on a derived
+  /// dialect attribute that appears on a function parameter. This gets called
+  /// after the function operation has been translated.
+  virtual LogicalResult
+  convertParameterAttr(LLVM::LLVMFuncOp function, int argIdx,
----------------
ftynse wrote:

```
$ git grep " int " | wc -l
1161
$ git grep " unsigned " | wc -l
3449
```

also most of the former is in tests or tools.

That being said, I'm not a proponent of using `unsigned` (I'd rather use `int32/64_t` throughout) , but I am a proponent of consistency.

https://github.com/llvm/llvm-project/pull/78228