[Mlir-commits] [mlir] [MLIR][EmitC] Emit private functions as static (PR #78336)

[Marius Brehler]

marbre wrote:

Thanks for the pull-request @AlexDenisov. I am not sure if the concept of an `private` symbol in MLIR or rather a `func.func private` directly matches with the C/C++ `static` keyword. However, I fully agree and see the need to emit static functions. I already have a `emitc.func` somewhere on my stack which should allow attributes like `static` and `inline` and could prioritize this if there is a need. This could also allow to implement a conversion pass that converts a `func.func` and `emitc.func` with `private` mapped to `static`. WDYT?

https://github.com/llvm/llvm-project/pull/78336