[Mlir-commits] [mlir] [mlir][LinAlg] Vectorize reverse-like ops using vector.gather ops. (PR #83205)
Andrzej Warzyński
llvmlistbot at llvm.org
Wed Feb 28 02:38:11 PST 2024
================
@@ -891,8 +891,7 @@ static bool isContiguousLoadIdx(LinalgOp &linalgOp, Value &val,
// Conservatively reject Ops that could lead to indices with stride other
// than 1.
- if (!isa<arith::AddIOp, arith::SubIOp, arith::ConstantOp, linalg::IndexOp>(
- ancestor))
+ if (!isa<arith::AddIOp, arith::ConstantOp, linalg::IndexOp>(ancestor))
----------------
banach-space wrote:
+1 to landing this as is
Both issues that you mention look like my oversight, sorry for that.
There’s quite a few cases for tensor.extract and I struggled to come up with good tests to cover all of them.
https://github.com/llvm/llvm-project/pull/83205
More information about the Mlir-commits
mailing list