[Mlir-commits] [mlir] Revert "[mlir][ExecutionEngine] Add support for global constructors and destructors" (PR #78164)

[Graham Markall]

gmarkall wrote:

> I doubt I'll look into it as it's not immediately obvious how to ensure that and I can't dig into it at the moment, but could be helpful if someone wants to, thanks for replying.

Understood. If you (or someone else) does want to try this, then after applying the changes in PR #71968, in https://github.com/llvm/llvm-project/pull/71968/files#diff-e576acec9556f141c95c5c7cb5f7f0caaa71b76ab65f67f95d88a169f933d720R110, change `ReserveAlloc = false` to `ReserveAlloc = true` - this just sets the default to reserve allocation space, and running your test again (perhaps repeatedly) should show whether it resolves the issue in your test.

I would also mention that the issue that the test shows up is a latent bug, so just removing support for global constructors and destructors doesn't fix the issue - it just removes a scenario that happens to trigger it.

https://github.com/llvm/llvm-project/pull/78164