[Mlir-commits] [mlir] Revert "[mlir][ExecutionEngine] Add support for global constructors and destructors" (PR #78164)

Cullen Rhodes llvmlistbot at llvm.org
Fri Feb 2 02:12:17 PST 2024


c-rhodes wrote:

> > his seems related to #71963 which there's an open PR [#71968](https://github.com/llvm/llvm-project/pull/71968) for, I've tested that patch but it doesn't fix the issue.
> 
> Just saw this - when you tested with that patch, did you do something to ensure that `SectionMemoryManager`s are constructed with `ReserveAlloc = true`? The PR #71968 doesn't change the default behaviour, so if that PR was only applied with no other changes, then I would not expect to see any difference.

No I didn't, just cherry-picked on top of the patch this reverts. That could explain it. I doubt I'll look into it as it's not immediately obvious how to ensure that and I can't dig into it at the moment, but could be helpful if someone wants to, thanks for replying.

https://github.com/llvm/llvm-project/pull/78164


More information about the Mlir-commits mailing list