[Mlir-commits] [mlir] [mlir] minor documentation fix in GPUTransformOps.td (PR #121157)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Thu Dec 26 09:12:34 PST 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir-gpu

Author: Oleksandr "Alex" Zinenko (ftynse)

<details>
<summary>Changes</summary>

 - do not refer to handles as `PDLOperation`, this is an outdated and incorrect vision of what they are based on the type used in the early days;
 - use backticks around inline code.

---
Full diff: https://github.com/llvm/llvm-project/pull/121157.diff


1 Files Affected:

- (modified) mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td (+5-5) 


``````````diff
diff --git a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
index 80b4547c32c101..61d4ccec5f0bd5 100644
--- a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
+++ b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
@@ -168,13 +168,13 @@ def MapNestedForallToThreads :
 
       #### Return modes:
 
-      This operation ignores non-gpu_launch ops and drops them in the return.
+      This operation ignores non-`gpu_launch` ops and drops them in the return.
 
       If any scf.forall with tensors is found, the transform definitely
       fails.
 
-      If all the scf.forall operations with gpu.thread mapping contained
-      within the LaunchOp referred to by the `target` PDLOperation lower to GPU
+      If all the `scf.forall` operations with gpu.thread mapping contained
+      within the `LaunchOp` referred to by the `target` handle lower to GPU
       properly, the transform succeeds. Otherwise the transform definitely
       fails.
 
@@ -277,8 +277,8 @@ def MapForallToBlocks :
     If any scf.forall with tensors is found, the transform definitely
     fails.
 
-    If all the scf.forall operations contained within the LaunchOp
-    referred to by the `target` PDLOperation lower to GPU properly, the
+    If all the `scf.forall` operations contained within the LaunchOp
+    referred to by the `target` handle lower to GPU properly, the
     transform succeeds. Otherwise the transform definitely fails.
 
     The returned handle points to the same LaunchOp operand, consuming it and

``````````

</details>


https://github.com/llvm/llvm-project/pull/121157


More information about the Mlir-commits mailing list