[Mlir-commits] [mlir] [mlir] minor documentation fix in GPUTransformOps.td (PR #121157)

Oleksandr Alex Zinenko llvmlistbot at llvm.org
Thu Dec 26 09:12:01 PST 2024


https://github.com/ftynse created https://github.com/llvm/llvm-project/pull/121157

 - do not refer to handles as `PDLOperation`, this is an outdated and incorrect vision of what they are based on the type used in the early days;
 - use backticks around inline code.

>From 72b13591d14e42abed5d14126536828172918eb6 Mon Sep 17 00:00:00 2001
From: Alex Zinenko <git at ozinenko.com>
Date: Thu, 26 Dec 2024 18:10:16 +0100
Subject: [PATCH] [mlir] minor documentation fix in GPUTransformOps.td

 - do not refer to handles as `PDLOperation`, this is an outdated and incorrect
 vision of what they are based on the type used in the early days;
 - use backticks around inline code.
---
 .../mlir/Dialect/GPU/TransformOps/GPUTransformOps.td   | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
index 80b4547c32c101..61d4ccec5f0bd5 100644
--- a/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
+++ b/mlir/include/mlir/Dialect/GPU/TransformOps/GPUTransformOps.td
@@ -168,13 +168,13 @@ def MapNestedForallToThreads :
 
       #### Return modes:
 
-      This operation ignores non-gpu_launch ops and drops them in the return.
+      This operation ignores non-`gpu_launch` ops and drops them in the return.
 
       If any scf.forall with tensors is found, the transform definitely
       fails.
 
-      If all the scf.forall operations with gpu.thread mapping contained
-      within the LaunchOp referred to by the `target` PDLOperation lower to GPU
+      If all the `scf.forall` operations with gpu.thread mapping contained
+      within the `LaunchOp` referred to by the `target` handle lower to GPU
       properly, the transform succeeds. Otherwise the transform definitely
       fails.
 
@@ -277,8 +277,8 @@ def MapForallToBlocks :
     If any scf.forall with tensors is found, the transform definitely
     fails.
 
-    If all the scf.forall operations contained within the LaunchOp
-    referred to by the `target` PDLOperation lower to GPU properly, the
+    If all the `scf.forall` operations contained within the LaunchOp
+    referred to by the `target` handle lower to GPU properly, the
     transform succeeds. Otherwise the transform definitely fails.
 
     The returned handle points to the same LaunchOp operand, consuming it and



More information about the Mlir-commits mailing list