[Mlir-commits] [mlir] [mlir] [test] Do not add dependencies on llvm tools in standalone builds (PR #120911)
llvmlistbot at llvm.org
llvmlistbot at llvm.org
Sun Dec 22 08:56:52 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-mlir
Author: Michał Górny (mgorny)
<details>
<summary>Changes</summary>
Since LLVM tools are installed system-wide, adding dependencies on them is unnecessary. Furthermore, it is problematic for multilib builds, where the tools are only built once, for the native ABI, and therefore are not listed in CMake files for non-native ABIs.
---
Full diff: https://github.com/llvm/llvm-project/pull/120911.diff
1 Files Affected:
- (modified) mlir/test/CMakeLists.txt (+3-1)
``````````diff
diff --git a/mlir/test/CMakeLists.txt b/mlir/test/CMakeLists.txt
index f181a91328f3fe..58d16a657297e6 100644
--- a/mlir/test/CMakeLists.txt
+++ b/mlir/test/CMakeLists.txt
@@ -99,7 +99,6 @@ configure_lit_site_cfg(
)
set(MLIR_TEST_DEPENDS
- FileCheck count not split-file
mlir-capi-ir-test
mlir-capi-irdl-test
mlir-capi-llvm-test
@@ -121,6 +120,9 @@ set(MLIR_TEST_DEPENDS
tblgen-lsp-server
tblgen-to-irdl
)
+if(NOT MLIR_STANDALONE_BUILD)
+ list(APPEND MLIR_TEST_DEPENDS FileCheck count not split-file)
+endif()
set(MLIR_TEST_DEPENDS ${MLIR_TEST_DEPENDS}
mlir-capi-pdl-test
``````````
</details>
https://github.com/llvm/llvm-project/pull/120911
More information about the Mlir-commits
mailing list