[Mlir-commits] [mlir] [mlir] [test] Do not add dependencies on llvm tools in standalone builds (PR #120911)

[Michał Górny]

https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/120911

Since LLVM tools are installed system-wide, adding dependencies on them is unnecessary.  Furthermore, it is problematic for multilib builds, where the tools are only built once, for the native ABI, and therefore are not listed in CMake files for non-native ABIs.

>From 5ddbf6670b683264f4136d3b6209c1f554b823e7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20G=C3=B3rny?= <mgorny at gentoo.org>
Date: Sun, 22 Dec 2024 17:54:26 +0100
Subject: [PATCH] [mlir] [test] Do not add dependencies on llvm tools in
 standalone builds

Since LLVM tools are installed system-wide, adding dependencies on them
is unnecessary.  Furthermore, it is problematic for multilib builds,
where the tools are only built once, for the native ABI, and therefore
are not listed in CMake files for non-native ABIs.
---
 mlir/test/CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/mlir/test/CMakeLists.txt b/mlir/test/CMakeLists.txt
index f181a91328f3fe..58d16a657297e6 100644
--- a/mlir/test/CMakeLists.txt
+++ b/mlir/test/CMakeLists.txt
@@ -99,7 +99,6 @@ configure_lit_site_cfg(
   )
 
 set(MLIR_TEST_DEPENDS
-  FileCheck count not split-file
   mlir-capi-ir-test
   mlir-capi-irdl-test
   mlir-capi-llvm-test
@@ -121,6 +120,9 @@ set(MLIR_TEST_DEPENDS
   tblgen-lsp-server
   tblgen-to-irdl
   )
+if(NOT MLIR_STANDALONE_BUILD)
+  list(APPEND MLIR_TEST_DEPENDS FileCheck count not split-file)
+endif()
 
 set(MLIR_TEST_DEPENDS ${MLIR_TEST_DEPENDS}
   mlir-capi-pdl-test