[Mlir-commits] [mlir] [polly] [mlir][polly][llvm-lit] Fixed logic for turning on external shell in lit (PR #106458)

[Paul Kirth]

ilovepi wrote:

The current RFC and plans are to incrementally adopt the internal shell as the default. The main lit config in llvm handles this correctly, but there is usually some special handling for Windows duplicated across the various subprojects. MLIR already had set it’s default for the internal shell, but this is rare for any of the subprojects to do outside of Windows. Polly had no tests with either non-portable syntax or REQUIRES: shell, so it wasn’t noticed that it didn’t work as intended when we adopted/copied the MLIR implementation. 

I’m not sure there’s a good way to share the implementation settings between subprojects without using the same settings for all of them. Using the shared implementation may need to wait until we’re ready to switch them all.

https://github.com/llvm/llvm-project/pull/106458