[Mlir-commits] [mlir] [polly] [mlir][polly][llvm-lit] Fixed logic for turning on external shell in lit (PR #106458)

Aiden Grossman llvmlistbot at llvm.org
Wed Aug 28 14:55:35 PDT 2024


https://github.com/boomanaiden154 approved this pull request.

LGTM.

It seems like the two instances in `polly` were copied from the MLIR one and the MLIR version was inverted for whatever reason?

Given this seems to impact all the test suites where the internal shell is getting enabled, is it possible/a good idea to move the use of the environment variable to within lit (maybe as a follow up)?

https://github.com/llvm/llvm-project/pull/106458


More information about the Mlir-commits mailing list