[Mlir-commits] [mlir] [mlir][StorageUniquer] Restore old signature for default implementaion of verifyInvariants. (PR #103023)

[Benjamin Chetioui]

https://github.com/bchetioui created https://github.com/llvm/llvm-project/pull/103023

PR #102326 changed the prototype of the default implementation of verify to include emitErrorFn.

This breaks automatic derivation in consumer attributes, such as https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53.

This PR simply restores the signature to what it was prior to PR #102326.

>From fa733c20f627825ebf88968061708f0ccab1a250 Mon Sep 17 00:00:00 2001
From: Benjamin Chetioui <bchetioui at google.com>
Date: Tue, 13 Aug 2024 08:44:10 +0000
Subject: [PATCH] [mlir][StorageUniquer] Restore old signature for default
 implementation of verifyInvariants.

PR #102326 changed the prototype of the default implementation of
verify to include emitErrorFn.

This breaks automatic derivation in consumer attributes, such as
https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53.

This PR simply restores the signature to what it was prior to PR #102326.
---
 mlir/include/mlir/IR/StorageUniquerSupport.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mlir/include/mlir/IR/StorageUniquerSupport.h b/mlir/include/mlir/IR/StorageUniquerSupport.h
index d6ccbbd8579947..c493fd9c5042c7 100644
--- a/mlir/include/mlir/IR/StorageUniquerSupport.h
+++ b/mlir/include/mlir/IR/StorageUniquerSupport.h
@@ -227,8 +227,7 @@ class StorageUserBase : public BaseT, public Traits<ConcreteT>... {
   /// Default implementation that just returns success.
   template <typename... Args>
   static LogicalResult
-  verifyInvariants(function_ref<InFlightDiagnostic()> emitErrorFn,
-                   Args... args) {
+  verifyInvariants(Args... args) {
     return success();
   }