[Mlir-commits] [mlir] Fix late comment review for #102038 (PR #102869)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Mon Aug 12 02:41:35 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Giuseppe Rossini (giuseros)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/102869.diff


1 Files Affected:

- (modified) mlir/lib/Transforms/Utils/RegionUtils.cpp (+2-1) 


``````````diff
diff --git a/mlir/lib/Transforms/Utils/RegionUtils.cpp b/mlir/lib/Transforms/Utils/RegionUtils.cpp
index dd75e283a36b8d..3c7523827699c8 100644
--- a/mlir/lib/Transforms/Utils/RegionUtils.cpp
+++ b/mlir/lib/Transforms/Utils/RegionUtils.cpp
@@ -1012,7 +1012,8 @@ static LogicalResult dropRedundantArguments(RewriterBase &rewriter,
 
     // Add any nested regions to the worklist.
     for (Block &block : *region) {
-      anyChanged = succeeded(dropRedundantArguments(rewriter, block));
+      anyChanged =
+          succeeded(dropRedundantArguments(rewriter, block)) || anyChanged;
 
       for (Operation &op : block)
         for (Region &nestedRegion : op.getRegions())

``````````

</details>


https://github.com/llvm/llvm-project/pull/102869


More information about the Mlir-commits mailing list